x.crypto.chacha20: makes underlying cipher routine aware of 64-bit counter
#24050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… process_in_thread in a lock in 1b52538, effectively disabled parallelism)
|
Connected to Huly®: V_0.6-22441 |
spytheman
approved these changes
Mar 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was the core part of adding support for 64-bit counter into
x.crypto.chacha20module.Its contains some bits of
chacha20.Ciphermethods to aware this new changes, its include mainchacha20_block_generickeystream generator.Most of the functionality to support for 64-bit counter was mostly completes. But, this PR does not fully activated support for 64-bit counter, its still fails when you try creates cipher with 64-bit counter.
My plan was after adding test files.
Thanks