Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v.vmod: add manifest encoder fn #24034

Merged
merged 2 commits into from
Mar 29, 2025
Merged

v.vmod: add manifest encoder fn #24034

merged 2 commits into from
Mar 29, 2025
+128 −2

Conversation

gechandesu
Copy link
Contributor

This PR:

  • Adds encoder function for v.mod
  • Adds tests

@huly-for-github Huly for GitHub
Copy link

Connected to Huly®: V_0.6-22427

@spytheman
Copy link
Member

Why is it needed?

@gechandesu
Copy link
Contributor Author

Why is it needed?

I plan to use it in vpm for editing v.mod (with v install, v remove), it can also be used in scaffolding utilities like v init.

@gechandesu
Copy link
Contributor Author

I think the CI failure is not related to this PR, can you please rerun checks?

@spytheman
Copy link
Member

Done, although it may need rebasing over the current master too.

@spytheman
Copy link
Member

It failed again, I will rebase it.

@gechandesu
Copy link
Contributor Author

Hmm, failing again, I have a look bit later. Make MR a draft for now

@gechandesu gechandesu marked this pull request as draft March 25, 2025 22:23
spytheman
spytheman reviewed Mar 25, 2025
View reviewed changes
@gechandesu gechandesu marked this pull request as ready for review March 29, 2025 12:29
spytheman
spytheman approved these changes Mar 29, 2025
View reviewed changes
Copy link
Member

@spytheman spytheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work.

@spytheman spytheman merged commit 991b121 into vlang:master Mar 29, 2025
62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spytheman spytheman spytheman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gechandesu @spytheman