x.crypto.chacha20: fix issue on consecutive calls of xor_key_stream
#24003
+225
−147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Connected to Huly®: V_0.6-22396 |
|
Thank you for taking care of this, very quickly too! |
|
I think the rest of the CI test still faills . I Will look into it asap . Updates |
nope |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixs the issue related consecutive calls of
xor_key_streamthats not handled correctly after the first calls. Its issue was reported by @einar-hjortdal . See the issue at 23977. Thank for report the issue.In this PR, we follow and adapt the go version and also unifies between
chach20_blockandgeneric_key_streammethod to single one in the form ofchacha20_block_generic. Its also adds a test for this consecutive calls issue.Thanks