Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

os: windows add is_pending() #23993

Merged
merged 2 commits into from
Mar 21, 2025
Merged

os: windows add is_pending() #23993

merged 2 commits into from
Mar 21, 2025

Conversation

kbkpbot
Copy link
Contributor

@kbkpbot kbkpbot commented Mar 21, 2025

Fix issue #23990

  1. add win_is_pending();
  2. modify windows stdout pipe / stderr pipe buffer length from 4KB to 64KB, this is the same of Linux version.

@huly-for-github Huly for GitHub
Copy link

Connected to Huly®: V_0.6-22386

spytheman
spytheman approved these changes Mar 21, 2025
View reviewed changes
Copy link
Member

@spytheman spytheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work.
Thank you 🙇🏻‍♂️.

@spytheman spytheman merged commit a130463 into vlang:master Mar 21, 2025
68 checks passed
@kbkpbot kbkpbot deleted the os-windows-is-pending branch March 21, 2025 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spytheman spytheman spytheman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kbkpbot @spytheman