tools: support // vtest build: !do_not_test ?, // vtest build: !windows && tinyc to skip files during testing on specific platforms, without having to keep centralised skip lists
#23900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Connected to Huly®: V_0.6-22302 |
|
YES! Excellent change. Keeping hard-coded lists in files is cumbersome, error prone, and causes more churn than necessary. |
JalonSolov
reviewed
Mar 11, 2025
spytheman
force-pushed
the
implement_vtest_build
branch
from
67c9128 to
718dbb1
Compare
JalonSolov
reviewed
Mar 11, 2025
…ndows && tinyc` to skip files during testing on specific platforms, without having to keep centralised skip lists
…dress-clang CI job" This reverts commit e7fe32bfc114d5e8e5965a8902bf748e2e24e836.
spytheman
force-pushed
the
implement_vtest_build
branch
from
5e60dc5 to
caa0823
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides a more general mechanism for skipping test files on specific platforms, by marking them with special build expression comments inside them, that are later checked by
v test, and evaluated against the current environment.In a later PR, after this is merged, that mechanism will be used for cleaning up
cmd/tools/modules/testing/common.v:222to line 323 (the logic for adding to the skip_files list is currently hard coded, and needs modification to the test runner).Given that the mechanism is general, it could be used by user test files too, and I have additional plans for making it work for normal .v files, since it is more general than the platform suffixes (the expressions can be much more complex, supporting &&, ||, !, and () ...)