Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

os: fix get_raw_line() under windows #23846

Merged
merged 9 commits into from
Mar 3, 2025
Merged

os: fix get_raw_line() under windows #23846

merged 9 commits into from
Mar 3, 2025

Conversation

kbkpbot
Copy link
Contributor

@kbkpbot kbkpbot commented Mar 2, 2025 •
edited
Loading

Fix issue #23843

  1. read 1 byte/char from file pipe/console every time, and check for \n and Ctrl+Z.
  2. add a example/get_raw_line.v as I don't know how to test it.

A discussion can be found at golang/go@610d522

@huly-for-github Huly for GitHub
Copy link

Connected to Huly®: V_0.6-22251

spytheman
spytheman reviewed Mar 2, 2025
View reviewed changes
spytheman
spytheman approved these changes Mar 3, 2025
View reviewed changes
Copy link
Member

@spytheman spytheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work.

@spytheman spytheman merged commit f4b51d0 into vlang:master Mar 3, 2025
68 checks passed
@kbkpbot kbkpbot deleted the fix-os-get-raw-2 branch March 3, 2025 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spytheman spytheman spytheman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kbkpbot @spytheman