-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x.encoding.asn1
: another minor cleanup
#22968
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
x.encoding.asn1
cleanupx.encoding.asn1
module cleanup
x.encoding.asn1
module cleanupx.encoding.asn1
: another minor cleanup
spytheman
reviewed
Nov 25, 2024
spytheman
reviewed
Nov 25, 2024
spytheman
reviewed
Nov 25, 2024
spytheman
reviewed
Nov 25, 2024
spytheman
approved these changes
Nov 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work.
Less code, more performance 🥳 !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is rather of
follow-up from previous PR in attempt to improves
x.encoding.asn1
module, as availables in 22948, 22932, 22861, and 22847 PRs.This PR contains some small changes to the module:
.str()
from sequence and set for now, its needed to allow just dump current sequence fields.RawElement
methodsThe latest bench run with
-prod
flag results inIts likely on par with the
go
version bench availables onbench
dir. The previous patch help reduces some overhead of it.Huly®: V_0.6-21409