Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scanner: remove Scanner.is_started field #22918

Merged
merged 2 commits into from
Nov 20, 2024
Merged

scanner: remove Scanner.is_started field #22918

merged 2 commits into from
Nov 20, 2024

Conversation

StunxFS
Copy link
Contributor

@StunxFS StunxFS commented Nov 19, 2024 •
edited
Loading

This PR simplifies the scanner, removing the is_started field from Scanner. Now, Scanner.pos will have a default value of -1.

Huly®: V_0.6-21361

spytheman
spytheman approved these changes Nov 20, 2024
View reviewed changes
Copy link
Member

@spytheman spytheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work.

@spytheman spytheman merged commit ad24dbd into vlang:master Nov 20, 2024
72 checks passed
@StunxFS StunxFS deleted the simplify_scanner branch November 20, 2024 03:27
@felipensp
Copy link
Member

Nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spytheman spytheman spytheman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@StunxFS @felipensp @spytheman