Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vweb: mark deprecated #22131

Merged
merged 3 commits into from
Aug 30, 2024
Merged

vweb: mark deprecated #22131

merged 3 commits into from
Aug 30, 2024

Conversation

esquerbatua
Copy link
Contributor

No description provided.

@medvednikov
Copy link
Member

yeah that's going to break a lot of tests :)

I wanted to deprecate it after adding implicit contexts to V, so that migration from vweb to veb is easier

I'll finish it this week

@spytheman
Copy link
Member

Can we please instead, just extract vlib/vweb to https://github.com/vlang/vweb , so that it can still be used by people that want it, by just doing v install vweb?

vweb -> veb is a breaking change, and can not be automated in the general case, without introducing lots of hacks and edge cases.

Making vweb deprecated, while it stays in vlib, is forcing people to migrate their projects to veb, without giving them time to do it.

@spytheman
Copy link
Member

adding implicit contexts to V

I think that doing this should be well thought out, and for general use, not just hacks to make the veb routes look more like the vweb ones.

@esquerbatua
Copy link
Contributor Author

Can we please instead, just extract vlib/vweb to https://github.com/vlang/vweb , so that it can still be used by people that want it, by just doing v install vweb?

vweb -> veb is a breaking change, and can not be automated in the general case, without introducing lots of hacks and edge cases.

Making vweb deprecated, while it stays in vlib, is forcing people to migrate their projects to veb, without giving them time to do it.

It's also a breaking change, maybe mark it as deprecated when veb it's ready? or only mark it at level of docs?

@esquerbatua esquerbatua marked this pull request as draft August 30, 2024 08:33
@spytheman
Copy link
Member

It's also a breaking change

Moving to a separate repo, is a breaking change, but with much less impact - with it, after v install vweb, all existing code that depends on it, will still compile, with no warnings at all.

@esquerbatua
Copy link
Contributor Author

Removed the deprecated tags

@esquerbatua esquerbatua marked this pull request as ready for review August 30, 2024 11:07
@spytheman spytheman merged commit 8ebc288 into vlang:master Aug 30, 2024
4 checks passed
@esquerbatua esquerbatua deleted the vweb/deprecate branch August 30, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants