Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vdoc: select first result when entering search term, use more explict query for header.doc-nav #21193

Merged
merged 1 commit into from
Apr 6, 2024

Conversation

ttytm
Copy link
Member

@ttytm ttytm commented Apr 5, 2024

Currently, there are some situations where search results are sub-optimally presented. For example, when opening a module site like https://modules.vlang.io/sync.html where the sidebar navigation on the left is already scrolled down. Then, upon entering a search term, such as str, the navigation remains scrolled down, the most relevant search results are not visible without manually scrolling up in the side bar. With the changes, upon entering a search term, the search navigation scrolls to the top.

… query for `header.doc-nav`
Copy link
Member

@spytheman spytheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work.

@spytheman spytheman merged commit 3d5dbca into vlang:master Apr 6, 2024
45 checks passed
@ttytm ttytm deleted the vdoc/select-first-result branch April 6, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants