Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

term: add missing documentation for all remaining public functions #17044

Merged
merged 1 commit into from
Jan 20, 2023
Merged

term: add missing documentation for all remaining public functions #17044

merged 1 commit into from
Jan 20, 2023

Conversation

nahuakang
Copy link
Contributor

Add missing documentation for all remaining public functions inside vlib/term/ per v missdoc vlib/term/ command for #7047.

The following could be updated to #7047:

  • vlib/term/control.v <- Done in this PR
  • vlib/term/term.v <- Done already
  • vlib/term/ui/input_nix.c.v <- Done in this PR
  • vlib/term/ui/input_windows.c.v <- Done in this PR
  • vlib/term/ui/termios_nix.c.v <- Done already
  • vlib/term/ui/ui.v <- Done in this PR

Delta456
Delta456 reviewed Jan 19, 2023
View reviewed changes
Delta456
Delta456 reviewed Jan 19, 2023
View reviewed changes
@nahuakang
Copy link
Contributor Author

@Delta456 Thanks for the suggestions :)

JalonSolov
JalonSolov reviewed Jan 19, 2023
View reviewed changes
JalonSolov
JalonSolov reviewed Jan 19, 2023
View reviewed changes
JalonSolov
JalonSolov reviewed Jan 19, 2023
View reviewed changes
JalonSolov
JalonSolov reviewed Jan 19, 2023
View reviewed changes
JalonSolov
JalonSolov reviewed Jan 19, 2023
View reviewed changes
JalonSolov
JalonSolov reviewed Jan 19, 2023
View reviewed changes
JalonSolov
JalonSolov reviewed Jan 19, 2023
View reviewed changes
JalonSolov
JalonSolov reviewed Jan 19, 2023
View reviewed changes
JalonSolov
JalonSolov reviewed Jan 19, 2023
View reviewed changes
JalonSolov
JalonSolov reviewed Jan 19, 2023
View reviewed changes
JalonSolov
JalonSolov reviewed Jan 19, 2023
View reviewed changes
JalonSolov
JalonSolov reviewed Jan 19, 2023
View reviewed changes
JalonSolov
JalonSolov reviewed Jan 19, 2023
View reviewed changes
JalonSolov
JalonSolov reviewed Jan 19, 2023
View reviewed changes
JalonSolov
JalonSolov reviewed Jan 19, 2023
View reviewed changes
JalonSolov
JalonSolov reviewed Jan 19, 2023
View reviewed changes
JalonSolov
JalonSolov reviewed Jan 19, 2023
View reviewed changes
@nahuakang
Copy link
Contributor Author

@JalonSolov Thank you too!

larpon
larpon approved these changes Jan 19, 2023
View reviewed changes
Copy link
Contributor

@larpon larpon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice 👍🏻

@spytheman spytheman merged commit 90dbf68 into vlang:master Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Delta456 Delta456 Delta456 left review comments

@JalonSolov JalonSolov JalonSolov left review comments

@larpon larpon larpon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nahuakang @larpon @Delta456 @JalonSolov @spytheman