Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in splitting on alt scene headings #2234

Merged
merged 2 commits into from
Feb 9, 2025
Merged

Fix bug in splitting on alt scene headings #2234

merged 2 commits into from
Feb 9, 2025

Conversation

vkbo
Copy link
Owner

@vkbo vkbo commented Feb 9, 2025 •
edited
Loading

Summary:

This PR adds the ###! alt scene format to the list of detected formats for the split document tool.

Related Issue(s):

Closes #2233

Reviewer's Checklist:

  • The header of all files contain a reference to the repository license
  • The overall test coverage is increased or remains the same as before
  • All tests are passing
  • All flake8 checks are passing and the style guide is followed
  • Documentation (as docstrings) is complete and understandable
  • Only files that have been actively changed are committed

@vkbo vkbo added this to the Release 2.6.2 milestone Feb 9, 2025
@vkbo vkbo changed the base branch from main to release February 9, 2025 14:16
@vkbo vkbo changed the title Fix bug in splitting on alt scene headers Fix bug in splitting on alt scene headings Feb 9, 2025
@vkbo vkbo merged commit c6991b3 into release Feb 9, 2025
8 checks passed
@vkbo vkbo deleted the split_alt_scene branch February 9, 2025 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 2.6.2
Development

Successfully merging this pull request may close these issues.

Split Document by Headings ignores alt. scenes (###!)
1 participant
@vkbo