Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose text margin settings in Manuscript Build #2051

Merged
merged 3 commits into from
Oct 17, 2024
Merged

Expose text margin settings in Manuscript Build #2051

merged 3 commits into from
Oct 17, 2024

Conversation

vkbo
Copy link
Owner

@vkbo vkbo commented Oct 17, 2024

Summary:

The text margin settings have always been there internally, but this PR adds them to the Build Settings form, and also makes the margin settings layout more compact.

In addition, this PR cleans up the code so that text sizes and margins are defined globally in constants.

Related Issue(s):

Related #2023

Reviewer's Checklist:

  • The header of all files contain a reference to the repository license
  • The overall test coverage is increased or remains the same as before
  • All tests are passing
  • All flake8 checks are passing and the style guide is followed
  • Documentation (as docstrings) is complete and understandable
  • Only files that have been actively changed are committed

@vkbo vkbo added this to the Release 2.6 Beta 1 milestone Oct 17, 2024
@vkbo vkbo linked an issue Oct 17, 2024 that may be closed by this pull request
@vkbo vkbo merged commit 464454e into main Oct 17, 2024
9 checks passed
@vkbo vkbo deleted the text_margins branch October 17, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modify build tool to support heading formatting
1 participant