Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward all scroll events in text area widgets to parent #1511

Merged
merged 2 commits into from
Aug 31, 2023
Merged

Conversation

vkbo
Copy link
Owner

@vkbo vkbo commented Aug 31, 2023

Summary:

This PR adds an event filter that will capture any mouse wheel scroll event on a widget and forward the event to the wheelEvent handler of the root widget. This solves the issue that scroll events in widget margins are ignored.

Related Issue(s):

Closes #1425
Duplicate #1474

Reviewer's Checklist:

  • The header of all files contain a reference to the repository license
  • The overall test coverage is increased or remains the same as before
  • All tests are passing
  • All flake8 checks are passing and the style guide is followed
  • Documentation (as docstrings) is complete and understandable
  • Only files that have been actively changed are committed

@vkbo vkbo added this to the Release 2.1 Beta 2 milestone Aug 31, 2023
@vkbo vkbo linked an issue Aug 31, 2023 that may be closed by this pull request
@vkbo vkbo merged commit 440256c into dev Aug 31, 2023
@vkbo vkbo deleted the editor_scrolling branch August 31, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow touchpad scrolling in text margins
1 participant