Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop saving fullscreen flag #1498

Merged
merged 2 commits into from
Aug 6, 2023
Merged

Drop saving fullscreen flag #1498

merged 2 commits into from
Aug 6, 2023

Conversation

vkbo
Copy link
Owner

@vkbo vkbo commented Aug 6, 2023

Summary:

This PR removes the caching of the full screen state to the config file. This never worked properly anyway since the full screen flag internally in Qt doesn't necessarily match the window manager.

This PR also adds annotations to the main GUI class.

Related Issue(s):

Reviewer's Checklist:

  • The header of all files contain a reference to the repository license
  • The overall test coverage is increased or remains the same as before
  • All tests are passing
  • All flake8 checks are passing and the style guide is followed
  • Documentation (as docstrings) is complete and understandable
  • Only files that have been actively changed are committed

@vkbo vkbo added this to the Release 2.1 RC 1 milestone Aug 6, 2023
@vkbo vkbo merged commit 97dccd9 into dev Aug 6, 2023
@vkbo vkbo deleted the drop_saving_fullscreen branch August 6, 2023 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant