Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MacOS release for 2.1b1 #1496

Merged
merged 8 commits into from
Jul 30, 2023
Merged

Fix MacOS release for 2.1b1 #1496

merged 8 commits into from
Jul 30, 2023

Conversation

vkbo
Copy link
Owner

@vkbo vkbo commented Jul 30, 2023 •
edited
Loading

Summary:

This PR fixes two issues:

  • An issue with dialog windows being hidden behind the main window in certain circumstances, like opening a file system dialog. These dialogs have now been marked as a "Tool", i.e. a Panel as far as MacOS is concerned. This is only applied for Mac.
  • The version number for the beta release is not allowed in the MacOS plist file, so it now just uses the numerical part.

A new DMG image for release 2.1-beta1 has been uploaded with these changes. The file is versioned as 2.1b1-post1.

Related Issue(s):

Closes #1494

Reviewer's Checklist:

  • The header of all files contain a reference to the repository license
  • The overall test coverage is increased or remains the same as before
  • All tests are passing
  • All flake8 checks are passing and the style guide is followed
  • Documentation (as docstrings) is complete and understandable
  • Only files that have been actively changed are committed

@vkbo vkbo added this to the Release 2.1 RC 1 milestone Jul 30, 2023
@vkbo vkbo linked an issue Jul 30, 2023 that may be closed by this pull request
Closing font dialog closes build tool on Mac #1494
Closed
@vkbo vkbo merged commit 352b70d into dev Jul 30, 2023
@vkbo vkbo deleted the mac_raise_fix branch July 30, 2023 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 2.1 RC 1
Development

Successfully merging this pull request may close these issues.

Closing font dialog closes build tool on Mac
1 participant
@vkbo