Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix escaped markdown not being cleaned up for HTML and ODT #1418

Merged
merged 2 commits into from
Apr 15, 2023

Conversation

vkbo
Copy link
Owner

@vkbo vkbo commented Apr 15, 2023

Summary:

This PR changes how escaped markdown characters are handled. Previously, they were handled in a post processing step that only actually worked for the document viewer.

The new implementation runs a utility function on each piece of text that goes into an HTML or ODT paragraph during the processing loop. This is now format-dependant and the post processing function itself has been removed.

Related Issue(s):

Closes #1412

Reviewer's Checklist:

  • The header of all files contain a reference to the repository license
  • The overall test coverage is increased or remains the same as before
  • All tests are passing
  • All flake8 checks are passing and the style guide is followed
  • Documentation (as docstrings) is complete and understandable
  • Only files that have been actively changed are committed

@vkbo vkbo added this to the Release 2.0.7 milestone Apr 15, 2023
@vkbo vkbo merged commit c45f786 into main Apr 15, 2023
@vkbo vkbo deleted the fix/escaped_markdown branch April 15, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Viewer renders escaped markdown syntax, Builder renders the backslash instead
1 participant