-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add download functionality to DAM folders #1230
Conversation
…ich returns a zip file of a folder
…oid unknown file type on download
- add generics to RowActionsItem and affected types to support component conversion
Co-authored-by: Johannes Obermair <48853629+johnnyomair@users.noreply.github.com>
have you tried that with a large number of files and large files? what are the limits this can handle? |
Don't know actually. Do you know a good way to test this rather than brute force with a lot of files?^^ |
what's bad about brute forcing (locally)? |
Nothing. Just a bit annoying to do and not that realistic for production^^ I did it anyways and it has no problems with huge files or a lot of them. It just takes a while. 3GB took like 20 seconds locally |
I tried to optimize the time it takes with Promise.all but it made it worse |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please merge main and resolve conflicts
@jomunker please fix the pipeline. Thanks! |
2494ca9
@johnnyomair I fixed the pipeline so we can merge this 2494ca9 |
This PR adds the functionality to download folders recursively in the DAM as ZIP.
Video Recordings
Screen.Recording.2023-08-16.at.16.35.13.mov
Screen.Recording.2023-08-16.at.16.37.45.mov