Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(jsx): add vite-react-jsx suggestion #4303

Closed
wants to merge 1 commit into from

Conversation

abhijit-hota
Copy link

@abhijit-hota abhijit-hota commented Jul 18, 2021

Description

The mentioned plugin is really helpful (and is maintained by a member of the Vite team) and could help users finding a (better ?) solution instead of the proposed way of just injecting the import statement in jsxInject which seems hacky.

Additional context

This comment here at #2369


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention. (Sorry, my commit message isn't valid.)
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

**Motivation:** The comment [here](vitejs#2369 (comment)) 
The mentioned plugin is really helpful (and is maintained by a member of the Vite team) and could help users finding a (better ?) solution instead of the proposed way of just injecting the `import` statement in `jsxInject` which seems hacky.
@Shinigami92 Shinigami92 added documentation Improvements or additions to documentation p1-chore Doesn't change code behavior (priority) labels Jul 18, 2021
@aleclarson
Copy link
Member

aleclarson commented Sep 17, 2021

Closing now that vite-react-jsx has been merged into the core as @vitejs/plugin-react.

We can reopen if this PR still has other improvements.

@aleclarson aleclarson closed this Sep 17, 2021
@abhijit-hota
Copy link
Author

abhijit-hota commented Sep 18, 2021

vite-react-jsx has been merged into the core as @vitejs/plugin-react

Wow! That's good to hear. Any specific release I should look out for?

Edit

Found it: https://github.com/vitejs/vite/tree/main/packages/plugin-react#vitejsplugin-react-

P.S. A couple of links are broken in the documentation and in a few Readmes.

Example
https://vitejs.dev/plugins/#vitejs-plugin-react-refresh
Mainly plugin-react-refresh --> plugin-react

@patak-dev
Copy link
Member

@abhijit-hota would you like to do a PR to correct them?

We will probably release a beta for the plugin on Monday/Tuesday

@abhijit-hota
Copy link
Author

@patak-js Sure! Will try to open a draft by EOD.

@abhijit-hota
Copy link
Author

Sorry for the unmet promise.
But I see it's resolved now. ( #5001 )

Thanks for the plugin!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation p1-chore Doesn't change code behavior (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants