Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: warn if define['process.env'] contains path key with a value #19517

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+21 −0
Open

feat: warn if define['process.env'] contains path key with a value #19517

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions packages/vite/src/node/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -790,6 +790,27 @@ function resolveEnvironmentOptions(
options.consumer ?? (isClientEnvironment ? 'client' : 'server')
const isSsrTargetWebworkerEnvironment =
isSsrTargetWebworkerSet && environmentName === 'ssr'

if (options.define?.['process.env']) {
const processEnvDefine = options.define['process.env']
if (typeof processEnvDefine === 'object') {
const pathKey = Object.entries(processEnvDefine).find(
// check with toLowerCase() to match with `Path` / `PATH` (Windows uses `Path`)
([key, value]) => key.toLowerCase() === 'path' && !!value,
)?.[0]
if (pathKey) {
logger.warnOnce(
colors.yellow(
`The \`define\` option contains an object with ${JSON.stringify(pathKey)} for "process.env" key. ` +
'It looks like you may have passed the entire `process.env` object to `define`, ' +
'which can unintentionally expose all environment variables. ' +
'This poses a security risk and is discouraged.',
),
)
}
}
}

const resolve = resolveEnvironmentResolveOptions(
options.resolve,
alias,
Expand Down