fix(optimizer): fix optimizeDeps.include
glob syntax for ./*
exports
#16230
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is a small inconsistency in
fast-glob
's output, which was making some regex to miss when./*
exports is used and this case was not covered by the current test case@vitejs/test-dep-optimize-exports-with-glob
. I made a quick fix to just cover this special case.I wrote in the comment, but the inconsistency can be replayed like this:
I quickly skimmed through fast-glob side, but I didn't find any special call out about this behavior. Vite side fix seems simple enough, so I went with this, but please let me know if you want to check with fast-glob further.
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).