Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support outlines in closures #633

Merged
merged 4 commits into from
Mar 7, 2023
Merged

Support outlines in closures #633

merged 4 commits into from
Mar 7, 2023

Conversation

jcp19
Copy link
Contributor

@jcp19 jcp19 commented Mar 6, 2023

No description provided.

@jcp19 jcp19 requested a review from Felalolf March 6, 2023 17:34
Felalolf
Felalolf approved these changes Mar 6, 2023
View reviewed changes
Copy link
Contributor

@Felalolf Felalolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you make sure that the offset computation that is used for the name of the outline block is fine too?

Felalolf
Felalolf requested changes Mar 7, 2023
View reviewed changes
Copy link
Contributor

@Felalolf Felalolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked it myself. The relativeId function is incorrect. It uses codeRoot, which returns the enclsoing closure. Instead, it must use some function that returns the enclosing function or method.

@jcp19 jcp19 merged commit dc72343 into master Mar 7, 2023
@jcp19 jcp19 deleted the joao-support-outline-closure branch March 7, 2023 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Felalolf Felalolf Felalolf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jcp19 @Felalolf