Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adts #580

Merged
merged 13 commits into from
Nov 29, 2022
Merged

Adts #580

merged 13 commits into from
Nov 29, 2022

Conversation

Felalolf
Copy link
Contributor

Adds adts without the derivable feature.

@Felalolf Felalolf requested review from ArquintL, jcp19 and Dspil November 27, 2022 13:02
jcp19
jcp19 approved these changes Nov 28, 2022
View reviewed changes
Copy link
Contributor

@jcp19 jcp19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not look at it super thoroughly, but it looks good

@jcp19
Copy link
Contributor

jcp19 commented Nov 29, 2022

I would be happy with merging this

@Felalolf
Copy link
Contributor Author

bors r+

@bors
Copy link
Contributor

bors bot commented Nov 29, 2022

Build succeeded:

@bors bors bot merged commit b2d9b42 into master Nov 29, 2022
@bors bors bot deleted the adts branch November 29, 2022 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcp19 jcp19 jcp19 approved these changes

@ArquintL ArquintL Awaiting requested review from ArquintL

@Dspil Dspil Awaiting requested review from Dspil

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Felalolf @jcp19