Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add distinction between shared and exclusive global variables #560

Merged
merged 17 commits into from
Nov 3, 2022

Conversation

jcp19
Copy link
Contributor

@jcp19 jcp19 commented Nov 1, 2022

No description provided.

@jcp19 jcp19 requested review from Felalolf, ArquintL and Dspil November 1, 2022 19:46
@jcp19 jcp19 changed the title Add distinction between shared and exclusive variables Add distinction between shared and exclusive global variables Nov 2, 2022
Copy link
Contributor

@Felalolf Felalolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some comments. After they are addressed, it is fine.

Comment on lines +204 to +211
case (v: in.GlobalVar) :: t / Exclusive if typ(ctx).isDefinedAt(t) =>
val (pos, info, errT) = v.vprMeta
val typ = ctx.typ(v.typ)
val vprExpr = vpr.FuncApp(
funcname = v.name.uniqueName,
args = Seq.empty
)(pos, info, typ, errT)
unit(vprExpr)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure right now, but should this not be in the file with the globals encoding?

@jcp19 jcp19 linked an issue Nov 3, 2022 that may be closed by this pull request
@jcp19 jcp19 merged commit f565a0c into master Nov 3, 2022
@jcp19 jcp19 deleted the joao-immutable-globals branch November 3, 2022 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for immutable/"exclusive" globals
3 participants