Encoding refactor #466
Merged
Encoding refactor #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
June 19, 2022 04:03
…y introduced another bug
jcp19
approved these changes
Jun 20, 2022
src/main/scala/viper/gobra/frontend/info/implementation/property/ConstantEvaluation.scala
Outdated
Show resolved
Hide resolved
src/main/scala/viper/gobra/translator/encodings/combinators/DefaultEncoding.scala
Show resolved
Hide resolved
src/main/scala/viper/gobra/translator/encodings/combinators/FinalTypeEncoding.scala
Show resolved
Hide resolved
src/main/scala/viper/gobra/translator/encodings/combinators/TypeEncoding.scala
Show resolved
Hide resolved
src/main/scala/viper/gobra/translator/encodings/interfaces/InterfaceEncoding.scala
Outdated
Show resolved
Hide resolved
Dspil
approved these changes
Jun 20, 2022
ArquintL
approved these changes
Jun 20, 2022
| arg <- ctx.predicate.predicateAccess(ctx)(cp.acc.op, in.FullPerm(cp.info)) | ||
| res = vpr.CurrentPerm(arg.loc)(pos, info, errT) | ||
| arg <- ctx.ass(in.Access(in.Accessible.Predicate(cp.acc.op), in.FullPerm(cp.info))(cp.info)) | ||
| pap = arg.asInstanceOf[vpr.PredicateAccessPredicate] |
There was a problem hiding this comment.
why did you choose not to offer predicateAccess anymore?
| @@ -296,7 +297,7 @@ class StringEncoding extends LeafTypeEncoding { | |||
| terminationMeasures = Vector(in.WildcardMeasure(None)(info)), | |||
| body = None | |||
| )(info) | |||
| val translatedFunc = ctx.pureMethod.pureFunction(func)(ctx) | |||
| val translatedFunc = ctx.function(func) | |||
There was a problem hiding this comment.
is this a mistake or just confusing that pureMethod.pureFunction becomes function?
| case meth: in.Method => ctx.method.method(meth)(ctx).res | ||
| case meth: in.PureMethod => ctx.pureMethod.pureMethod(meth)(ctx).res | ||
| case meth: in.Method => ctx.method(meth).res | ||
| case meth: in.PureMethod => ctx.function(meth).res |
There was a problem hiding this comment.
same here: should we think about method and function in the Viper way?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changeset looks worse than it is. This PR:
TypeEncodingtrait.