Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Mem predicate in Error #457

Merged
merged 6 commits into from
May 23, 2022
Merged

Add Mem predicate in Error #457

merged 6 commits into from
May 23, 2022

Conversation

jcp19
Copy link
Contributor

@jcp19 jcp19 commented May 20, 2022 •
edited
Loading

This PR introduces a predicate ErrorMem in the error interface. An instance of this predicate is required to be able to call the Error method.

This PR also addresses the cyclic import error that is caused when ErrorMem is introduced. To solve that, we remove the call to method tryUnqualifiedBuiltInPackageLookup in method tryUnqualifiedPackageLookup when the importing package is builtin.

@jcp19 jcp19 linked an issue May 21, 2022 that may be closed by this pull request
error does not have a Mem() predicate #350
Closed
@jcp19 jcp19 marked this pull request as ready for review May 21, 2022 20:55
@jcp19 jcp19 mentioned this pull request May 21, 2022
Merged
@jcp19
Copy link
Contributor Author

jcp19 commented May 21, 2022 •
edited
Loading

I cannot reproduce these errors locally

@jcp19 jcp19 requested review from ArquintL and Dspil May 21, 2022 22:10
@jcp19 jcp19 requested a review from Felalolf May 22, 2022 18:52
@jcp19 jcp19 merged commit 7e8cac4 into master May 23, 2022
@jcp19 jcp19 deleted the fix-350 branch May 23, 2022 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dspil Dspil Dspil approved these changes

@Felalolf Felalolf Felalolf approved these changes

@ArquintL ArquintL Awaiting requested review from ArquintL

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

error does not have a Mem() predicate
3 participants
@jcp19 @Dspil @Felalolf