getOptions > refactor code for reuse through multiple ESLibs #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have forked this repository and created PR from it. So I can't set the assignee or reviewer for this PR. Sorry about that! |
phucbm
requested changes
Jan 10, 2023
There was a problem hiding this comment.
Make sure getOptions is identical to the merged version from Easy Tab Accordion.
vuquangpham
commented
Jan 12, 2023
src/helpers.js
Outdated
Comment on lines
25
to
30
| if(attributeIsNotJSON){ | ||
| options = defaultOptions; | ||
|
|
||
| // data attribute exist => string | ||
| if(dataAttribute) options.id = dataAttribute; | ||
| else options.id = ''; |
There was a problem hiding this comment.
I have added a small condition to remove the id from default options (for getting the id with the right priority below purpose).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Write the same
getOptionsfunction for making our code reusable and using through multiple ES Libraries (or any library that needs to get options from data-attribute) :With the new
getOptionsfunction, we can get options and override them for each library option through data-attribute