Fix reloading entities ids (fixes: #52) #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # EFCore.BulkExtensions/SqlAdapters/MySql/SqlQueryBuilderMySql.cs
…apping # Conflicts: # EFCore.BulkExtensions.Tests/BulkInsertOrUpdate/BulkInsertOrUpdateTests.cs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #52
Currently reload of the ids is dependent on the order (and also count) of the returned ids from db (which is not guaranteed). This add artificial column which maps original index in the input entities list to db generated id to guarantee correctness of returned id.
Implemneted for SQL Server. Before merge fixes are still needed in the MySQL