Fixed BulkInsert throwing an exception with custom column name on SQLite #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This update fixes an exception that was thrown when using a custom column name in SQLite. When using a custom column name, the custom name was used as the parameter name. Upon setting the parameter, however, it tried to set the parameter with the property name instead. This commit fixes this error by using the property name in both places.
videokojot
approved these changes
May 1, 2024
|
@videokojot hey, when can we expect release with this fix? |
|
@triforcely hi, sorry for the delay - released new version: |
|
@videokojot thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #124, which is that an exception was thrown when using a custom column name in SQLite.
The reason for this exception is that the custom column name was used as the parameter name for insertions when generating the command. However, when setting the parameters, it tried to set the parameter with the property name instead. This PR fixes this error by using the property name in both places.