Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(package): update videojs-vtt.js to version 0.15.2 #6333

Merged
merged 2 commits into from
Dec 2, 2019
Merged

fix(package): update videojs-vtt.js to version 0.15.2 #6333

merged 2 commits into from
Dec 2, 2019

Conversation

gkatsev
Copy link
Member

@gkatsev gkatsev commented Nov 26, 2019

Closes #6332

@gkatsev gkatsev mentioned this pull request Nov 26, 2019
Merged
@gkatsev gkatsev added the needs: LGTM Needs one or more additional approvals label Nov 26, 2019
@misteroneill misteroneill removed the needs: LGTM Needs one or more additional approvals label Dec 2, 2019
@gkatsev gkatsev merged commit 7bbd0ca into master Dec 2, 2019
@gkatsev gkatsev deleted the greenkeeper/videojs-vtt.js-0.15.2 branch December 2, 2019 19:13
gkatsev added a commit that referenced this pull request Dec 2, 2019
@gkatsev
fix: turn on strict mode again (#6334)
ca84448 
We had to turn off strict mode (#4551) in Video.js due to a change in vtt.js. That has now been fixed in videojs/vtt.js#40 and released as part of 0.15.2 which will be available via #6333.

Fixes videojs/vtt.js#15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@misteroneill misteroneill misteroneill approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gkatsev @misteroneill