Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update user-select none #4678

Merged
merged 3 commits into from
Oct 30, 2017
Merged

update user-select none #4678

merged 3 commits into from
Oct 30, 2017

Conversation

kocoten1992
Copy link
Contributor

gkatsev
gkatsev reviewed Oct 23, 2017
View reviewed changes
Copy link
Member

@gkatsev gkatsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Can you update the style so comments are above the string and they're all aligned left, to match the rest of the code?
I can make the change when merging, otherwise.

misteroneill
misteroneill approved these changes Oct 23, 2017
View reviewed changes
Copy link
Member

@misteroneill misteroneill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with @gkatsev, but otherwise approved.

@gkatsev gkatsev merged commit 43ddc72 into videojs:master Oct 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@misteroneill misteroneill misteroneill approved these changes

@gkatsev gkatsev gkatsev approved these changes

Assignees
No one assigned
Labels
confirmed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kocoten1992 @misteroneill @gkatsev @brandonocasey