Add GA note to primary readme #4481
Conversation
mmcc
force-pushed
the
mmcc/google-analytics-note
branch
from
8b937a4 to
0003588
Compare
README.md
Outdated
| > For the latest version of video.js and URLs to use, check out the [Getting Started][getting-started] page on our website. | ||
|
|
||
| > We include a [stripped down Google Analytics pixel](https://github.com/videojs/cdn/blob/master/src/analytics.js) that tracks a random sampling (currently 1%) of players loaded from the CDN. This allows us to see (roughly) what browsers are in use in the wild, along with other useful metrics such as OS and device. If you'd like to disable analytics, you can simply include the following global before including Video.js via the free CDN: |
There was a problem hiding this comment.
Just to be extra explicit that this is the CDN version how about "Only the CDN version of Video.js includes this analytics pixel. If you'd like to use the CDN hosted version but would like to disable analytics, you can simply..."
There was a problem hiding this comment.
Sorry, I've been in the African bush (literally) and just saw this 😬 I'll update the PR when I get to more reliable internets.
|
@mister-ben @OwenEdwards Made the update to be more explicit, let me know what you all think. |
README.md
Outdated
| > ```html | ||
| > <script>window.HELP_IMPROVE_VIDEOJS = false;</script> | ||
| > ``` | ||
|
|
There was a problem hiding this comment.
Suggest that we add something like "Alternatively, you can include Video.js in your website using npm or Bower - those distributions do not include the Google Analytics tracking." here, too.
|
"CDN hosted" could be more specific to make it clear it's the version hosted on vjs.zencdn.net only, and not anything you'd find on unpkg, cdnjs etc. |
|
@mmcc @mister-ben @OwenEdwards I made a PR against this branch with changes: mmcc#10 |
mention alternatives
|
And it's been merged here. |
|
Merged this. If we think there are other additions, please make a PR or post here and we can update it again. |
We already added a similar note to the getting started guide on the website, so it should probably be here too for the folks that don't make it off Github.