Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: EventTarget is also evented #3990

Merged
merged 1 commit into from
Jan 30, 2017
Merged

fix: EventTarget is also evented #3990

merged 1 commit into from
Jan 30, 2017

Conversation

gkatsev
Copy link
Member

@gkatsev gkatsev commented Jan 27, 2017

If you try to delegate an to an EventTarget from an evented component, you'll end up failing because it didn't think that an EventTarget object worked. But it should and does. This adds a check for it in the isEvented function.

@gkatsev gkatsev mentioned this pull request Jan 27, 2017
Merged
misteroneill
misteroneill approved these changes Jan 30, 2017
View reviewed changes
Copy link
Member

@misteroneill misteroneill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching that. Glad it was simple.

@gkatsev gkatsev merged commit e34335b into master Jan 30, 2017
@gkatsev gkatsev deleted the evented-eventtarget branch January 30, 2017 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@misteroneill misteroneill misteroneill approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gkatsev @misteroneill