Return the native Promise from play() #3907
Conversation
|
|
brandonocasey
changed the title
return native play value if possible when play is called
| this.tech_.one('loadstart', function() { | ||
| this.play(); | ||
| }); | ||
| return this.techGet_('play'); |
There was a problem hiding this comment.
oh, this is an interesting case for the techget/techcall dichotomy. play is still technically a setter, which is why techcall is used, but we want its return value. I wonder if we need to get rid the the difference. This is particularly important because of how middleware work. We're bubbling techCalls from the player to the tech and techGets from the tech to the player.
There was a problem hiding this comment.
I also think that we should get rid of the difference
| } | ||
|
|
||
| return this; | ||
| this.tech_.one('loadstart', function() { |
There was a problem hiding this comment.
If there's a source but it's of an unknown type, this throws as this.tech_ is undefined.
There was a problem hiding this comment.
should I just wrap the loadstart listener in an if (this.tech_) check then?
|
@mister-ben Could you take another look at this? I think the issue you brought up was addressed. |
|
Sure, will get a chance to look properly next week. |
|
so on chrome 62 where native videoTag.play() returns promise this should return promise right? i am asking becouse it does not return anything |
|
Video.js 6 will, yes. Video.js 5 will not. |
Description
Return a Promise from
play()originally this was a PR off of #3860 (https://github.com/BrandonOCasey/video.js/pull/4). This has been changed to be standalone.Requirements Checklist