Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing some broken links in guides #2965

Closed
wants to merge 1 commit into from
Closed

fixing some broken links in guides #2965

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/guides/languages.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ Language Codes
--------------
The following is a list of official language codes.

**NOTE:** For supported language translations, please see the [Languages Folder (/lang)](../../lang) folder located in the project root.
**NOTE:** For supported language translations, please see the [Languages Folder (/lang)](https://github.com/videojs/video.js/tree/master/lang) folder located in the project root.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This relative URL seems to work fine on Github, where's the problem?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These docs don't really live on github anymore -they get copied to the/docs
repo and deployed on docs.videojs.com, so the links have to be fixed for
that.

On Sun, Jan 3, 2016 at 19:20 Thijs Triemstra notifications@github.com
wrote:

In docs/guides/languages.md
#2965 (comment):

@@ -153,7 +153,7 @@ Language Codes

The following is a list of official language codes.

-NOTE: For supported language translations, please see the Languages Folder (/lang) folder located in the project root.

This relative URL seems to work fine on Github, where's the problem?

—
Reply to this email directly or view it on GitHub
https://github.com/videojs/video.js/pull/2965/files#r48699395.

Robert Crooks
Director of Learning Services
Brightcove, Inc

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, +1


<table border="0" cellspacing="5" cellpadding="5">
<tr>
Expand Down
4 changes: 2 additions & 2 deletions docs/guides/removing-players.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,11 @@ Sometimes, you want to remove players after page load (in single page apps or mo
Call `.dispose()`
-----------------

To remove the html associated with your videojs player from the page always call the player's [`dispose()`](https://github.com/videojs/video.js/blob/stable/docs/api/vjs.Player.md#dispose) method:
To remove the html associated with your videojs player from the page always call the player's [`dispose()`](http://docs.videojs.com/docs/api/player.html#Methodsdispose) method:

```javascript```
var oldPlayer = document.getElementById('my-player');
videojs(oldPlayer).dispose();
videojs(oldPlayer).dispose();
```

This method will:
Expand Down
2 changes: 1 addition & 1 deletion docs/guides/skins.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ enabled, you'll need to manually include them.

## Icons

You can view all of the icons available in the base theme by renaming and viewing [`icons.html.example`](../../sandbox/icons.html.example) in the sandbox directory.
You can view all of the icons available in the base theme by renaming and viewing [`icons.html.example`](https://github.com/videojs/video.js/blob/master/sandbox/icons.html.example) in the sandbox directory.

## Customization

Expand Down