Options in data-setup attribute are ignored when the initialization is called before autoSetup

[chikathreesix]

Because only vjs.autoSetup picks the option from data-setup, this attribute will be ignored if the initialization is called before that. Sometimes I face this issue and options in data-setup are ignored, so I made Player.getTagSetting pick the option from data-setup as well.

[heff]

Interesting, thanks! I don't think we've run into this before because most people either use autoSetup by itself,

<video data-setup="[options]"></video>

or they don't use the data-setup attribute and pass in the options in the init function

<video> </video>
videojs(id, options)

But I could see there potentially being a situation where you have two async scripts, the autoSetup scripts and another script that references the player, and that would cause this issue. Is that the situation you have?

[heff]

If we're doing this here now we should also remove it from the autoSetup script. And move the code comments over from there over to this one. Just the "If empty string, make it a parsable json object" one.

video.js/src/js/setup.js

Line 31 in b65f2da

options = vjs.JSON.parse(options || '{}');

[chikathreesix]

Thank you for your quick response! Yes, that's what exactly my situation is. Because a few of my scripts refer the Player instance, not sure who to be the first. Therefore I am having the option in data-setup.
By the way, I've fixed my code according to your comments.

[mmcc]

Thanks! This looks good to me, so we should pull this into the next release.

[chikathreesix]

Thanks!

[heff]

Good to go for this week's release.

[heff]

Merged in. Thank you!

[chikathreesix]

Thank you!