-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switching between sources with diffrenet technologies causes problem #882
Comments
When you change the source are you including the type information? e.g. |
@heff : Yes, I've also included the type for the new video but when the new video start playing the currentTime stays zero! |
Can you give us a reduced test case using something like JSBin? |
@mmcc : I couldn't run my test case on JSBin, so I've uploaded that on another server: http://w3group.org/videojs.html Please wait until player start playing, then click on Change Source 1 link and then click on Change Source 2 link. Here is the js: var player;
$(document).ready(function() {
player = videojs('my_video_1', {
techOrder: ['flash', 'html5'],
autoplay: true,
sources: [{
type: "video/flv",
src: "http://www.longtailvideo.com/jw/upload/bunny.flv"
}]
});
$('a.one').on('click', function() {
changeSource({
type: "video/webm",
src: "http://upload.wikimedia.org/wikipedia/mediawiki/d/d1/Wikipedia_on_Google_Glass_screencast_test.webm"
});
});
$('a.two').on('click', function() {
changeSource({
type: "video/flv",
src: "http://www.mediacollege.com/video-gallery/testclips/20051210-w50s_56K.flv"
});
});
});
function changeSource(src) {
player.pause();
player.currentTime(0);
player.src(src);
player.ready(function() {
this.one('loadeddata', videojs.bind(this, function() {
this.currentTime(0);
}));
this.load();
this.play();
});
} |
Sorry for the delay! I just confirmed, this is still a problem as of 4.4.2, so we'll look into it. Here's a JS Fiddle with updated VJS includes for future testing. |
Just wanted to chime in that this isn't just going from HTML5 to Flash. I'm using this plugin: |
@triwav so to clarify, you're saying it's switching from any tech to Flash? I think there are actually some related issues open, but I can't think of them off the top of my head. |
Can't say for certain if it's EVERY single one but just saying both on HTML5 to Flash as well as the chromecast plugin tech to Flash both cause this issue. 4.7.2 mentions Fixed a case where timeupdate events were not firing, and fixed and issue with the Flash player version. I haven't tried it on that or newer yet. I'll try to test in the coming week and report if it's indeed solved. |
@triwav have you already found a solution for this? Im currently fixing it in kim-company/videojs-chromecast#5 |
@philipgiuliani I haven't had a chance to look into this yet. Any fix would be appreciated. I have made some changes to build additional functionality. Not sure if you're trying to make your change solely for this issue or if you'd be interested in building in some additional functionality. |
@triwav i will built in some additional functionality. Already added some new features. Take a look if you want to support it. The master is currently only tested with Video.JS 4.3. |
Considering the original author hasn't done anything with the plugin, it looks like you might be the only one to move things forward. If you PM your email I can send you my current version of the file. I don't have the time to push changes unfortunately though. |
Its possible to send PM's over GitHub? |
@mmcc he hasn't found a solution for this yet, and me neither :( He just sent me a copy because he had fixed some other bugs out from the plugin. I will also take a look and report as soon as i found a solution. |
Pretty sure this is closed by #2125, but if not ping this thread and we'll reopen. |
In my case this is the techOrder:
everything works fine while I'm using file types which are supported by Html5 tech, however as soon as I pass on a file type which is not supported by html5 and it requires the tech to be switched to Flash everything start acting weird for example the play progress bar doesn't work anymore or the currrentTime always stays on zero.
My best guess here is that Flash player couldn't trigger events anymore.
The text was updated successfully, but these errors were encountered: