Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Captions on bottom on Chrome 43 #2193

Closed
TearsDontFalls opened this issue May 22, 2015 · 10 comments
Closed

Captions on bottom on Chrome 43 #2193

TearsDontFalls opened this issue May 22, 2015 · 10 comments

Comments

@TearsDontFalls
Copy link

Since a few days and a chrome auto update, the captions of all Video.js players are always at bottom:0

Tested+affected: Windows 7 + Chrome 43
Tested+unaffected: Chrome 42 on Android, Windows 7 + Firefox 38

Example Screenshot of http://www.videojs.com/ :
image

@heff
Copy link
Member

heff commented May 22, 2015

Hmm, that's annoying. Did the shadow dom class names change? I was pretty
sure we had CSS pushing the captions up, but I'm not finding it.

On Fri, May 22, 2015 at 9:21 AM, TearsDontFalls notifications@github.com
wrote:

Since a few days and a chrome auto update, the captions of all Video.js
players are always at bottom:0

Tested+affected: Windows 7 + Chrome 43
Tested+unaffected: Chrome 42 on Android, Windows 7 + Firefox 38

Example Screenshot of http://www.videojs.com/ :
[image: image]
https://cloud.githubusercontent.com/assets/1379201/7774936/2304f9f2-00af-11e5-8de3-9646ed29c4c5.png


Reply to this email directly or view it on GitHub
#2193.

@TearsDontFalls
Copy link
Author

On Chrome its using native tracks(so also no caption settings), so something is bugging there i think.

Found a quick workaround for now: Set these settings to false

if (options.nativeCaptions === false || options.nativeTextTracks === false) {
and it works as it isnt using native track support.

@heff
Copy link
Member

heff commented May 22, 2015

Yeah, you can disable native captions, but long term I think we want to rely on Chrome's native captions because people can set the captions settings once and use them across sites. I thought we had CSS that pushed the captions up using the shadow dom.

@ksheurs
Copy link

ksheurs commented May 26, 2015

Not sure if this is recommended, but this has been working for us:

video::-webkit-media-text-track-container {
  bottom: 0.75em;
}

@mmcc
Copy link
Member

mmcc commented May 26, 2015

Yep, seems reasonable to me, just kinda stinks that one of the only references I could find to this shadow selector was Sam Dutton's website.

@gkatsev
Copy link
Member

gkatsev commented May 27, 2015

If you enable the shadow DOM in Chrome dev tools, you can see the selectors you could use.

@mmcc
Copy link
Member

mmcc commented Jun 3, 2015

Someone want to put together a PR for this? @ksheurs?

@EZWrighter
Copy link

This affects Safari as well: #1904

@gkatsev
Copy link
Member

gkatsev commented Aug 19, 2015

It seems like ::-webkit-media-text-track-container on safari is doing weird stuff. Like, the caption shows up in the appropriate place (say 2em up) but then moves up another 2ems...

@chemoish
Copy link
Member

+1

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

7 participants