Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

5.0.0-1 does not expose plugin() on videojs object. #2102

Closed
dconnolly opened this issue Apr 30, 2015 · 0 comments
Closed

5.0.0-1 does not expose plugin() on videojs object. #2102

dconnolly opened this issue Apr 30, 2015 · 0 comments

Comments

@dconnolly
Copy link
Contributor 

> console.log(videojs);
2015-04-30 14:19:36.426 VM2029:2 videojs(id, options, ready)
undefined
> videojs.plugin('foo')
VM2031:2 Uncaught TypeError: videojs.plugin is not a function

This breaks existing plugins.
dconnolly added a commit to dconnolly/video.js that referenced this issue Apr 30, 2015
@dconnolly
Expose videojs.plugin()
e445006 
So that plugins can be registered with the same api!  Also a unit test
module for the video.js entrypoint.

Fixes videojs#2102
@dconnolly dconnolly mentioned this issue Apr 30, 2015
Closed
@mmcc mmcc closed this as completed Aug 12, 2015
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Expose videojs.plugin() dconnolly/video.js
2 participants
@dconnolly @mmcc