Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poster never displays if not set on creation #1567

Closed
dmlap opened this issue Oct 7, 2014 · 3 comments
Closed

Poster never displays if not set on creation #1567

dmlap opened this issue Oct 7, 2014 · 3 comments

Comments

@dmlap
Copy link
Member

dmlap commented Oct 7, 2014

If no poster image is assigned when video.js is initialized, the poster div is explicitly hidden. If a poster is assigned later, the poster component is never re-shown.

@heff
Copy link
Member

heff commented Oct 7, 2014

Everything is set up to make that work except we need to switch the poster css to use vjs-has-started (to hide it) and remove the on('play', hide)

@heff
Copy link
Member

heff commented Oct 7, 2014

Found one odd browser behavior here that's worth noting. In Chrome/Safari, if you set the video element's poster after the video has started playing, the poster will show and hide the video while the video keeps playing. I can't think of a real use case for doing that, but Firefox doesn't show the poster, which seems more correct.

heff added a commit to heff/video.js that referenced this issue Oct 16, 2014
@heff
Copy link
Member

heff commented Oct 16, 2014

closed by #1568

@heff heff closed this as completed Oct 16, 2014
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants