@eXon began Tech 2.0 work, improved how tech events are handled by th…

…e player. closes #2057

closes #1485

.jshintrc

@@ -12,6 +12,7 @@
     "undef"    : true,
     "laxbreak" : true,
     "esnext"   : true,
+    "eqeqeq"   : true,
     "predef"   : [
         "_V_",
         "goog",

CHANGELOG.md

@@ -27,6 +27,7 @@ CHANGELOG
 * @gkatsev added error logging for bad JSON formatting ([view](https://github.com/videojs/video.js/pull/2113))
 * @gkatsev added a sensible toJSON function ([view](https://github.com/videojs/video.js/pull/2114))
 * @bc-bbay fixed instance where progress bars would go passed 100% ([view](https://github.com/videojs/video.js/pull/2040))
+* @eXon began Tech 2.0 work, improved how tech events are handled by the player ([view](https://github.com/videojs/video.js/pull/2057))
 
 --------------------
 

src/js/button.js

@@ -69,7 +69,7 @@ class Button extends Component {
   // KeyPress (document level) - Trigger click when keys are pressed
   handleKeyPress(event) {
     // Check for space bar (32) or enter (13) keys
-    if (event.which == 32 || event.which == 13) {
+    if (event.which === 32 || event.which === 13) {
       event.preventDefault();
       this.handleClick();
     }

src/js/component.js

@@ -59,8 +59,7 @@ class Component {
     // If there was no ID from the options, generate one
     if (!this.id_) {
       // Don't require the player ID function in the case of mock players
-      let id = player.id && player.id() || 'no_player';
-
+      let id = player && player.id && player.id() || 'no_player';
       this.id_ = `${id}_component_${Lib.guid++}`;
     }
 
@@ -1033,7 +1032,7 @@ class Component {
    */
   enableTouchActivity() {
     // Don't continue if the root player doesn't support reporting user activity
-    if (!this.player().reportUserActivity) {
+    if (!this.player() || !this.player().reportUserActivity) {
       return;
     }
 

src/js/control-bar/playback-rate-menu/playback-rate-menu-item.js

@@ -28,7 +28,7 @@ class PlaybackRateMenuItem extends MenuItem {
   }
 
   update() {
-    this.selected(this.player().playbackRate() == this.rate);
+    this.selected(this.player().playbackRate() === this.rate);
   }
 
 }

src/js/control-bar/progress-control/seek-bar.js

@@ -51,7 +51,7 @@ class SeekBar extends Slider {
     let newTime = this.calculateDistance(event) * this.player_.duration();
 
     // Don't let video end while scrubbing.
-    if (newTime == this.player_.duration()) { newTime = newTime - 0.1; }
+    if (newTime === this.player_.duration()) { newTime = newTime - 0.1; }
 
     // Set new time (tell player to seek to new time)
     this.player_.currentTime(newTime);

src/js/control-bar/text-track-controls/chapters-button.js

@@ -48,7 +48,7 @@ class ChaptersButton extends TextTrackButton {
 
     for (let i = 0, l = tracks.length; i < l; i++) {
       let track = tracks[i];
-      if (track['kind'] == this.kind_) {
+      if (track['kind'] === this.kind_) {
         if (!track.cues) {
           track['mode'] = 'hidden';
           /* jshint loopfunc:true */

src/js/control-bar/text-track-controls/text-track-button.js

@@ -62,4 +62,4 @@ class TextTrackButton extends MenuButton {
 }
 
 MenuButton.registerComponent('TextTrackButton', TextTrackButton);
-export default TextTrackButton;
+export default TextTrackButton;

src/js/core.js

@@ -74,7 +74,7 @@ var videojs = function(id, options, ready){
 
 // CDN Version. Used to target right flash swf.
 videojs.CDN_VERSION = '__VERSION_NO_PATCH__';
-videojs.ACCESS_PROTOCOL = ('https:' == document.location.protocol ? 'https://' : 'http://');
+videojs.ACCESS_PROTOCOL = ('https:' === document.location.protocol ? 'https://' : 'http://');
 
 /**
 * Full player version

src/js/events.js

@@ -168,7 +168,7 @@ var on = function(elem, type, fn){
     };
   }
 
-  if (data.handlers[type].length == 1) {
+  if (data.handlers[type].length === 1) {
     if (elem.addEventListener) {
       elem.addEventListener(type, data.dispatcher, false);
     } else if (elem.attachEvent) {

src/js/lib.js

@@ -23,7 +23,7 @@ var createEl = function(tagName='div', properties={}){
     // add the attribute "role". My guess is because it's not a valid attribute in some namespaces, although
     // browsers handle the attribute just fine. The W3C allows for aria-* attributes to be used in pre-HTML5 docs.
     // http://www.w3.org/TR/wai-aria-primer/#ariahtml. Using setAttribute gets around this problem.
-    if (propName.indexOf('aria-') !== -1 || propName == 'role') {
+    if (propName.indexOf('aria-') !== -1 || propName === 'role') {
      el.setAttribute(propName, val);
     } else {
      el[propName] = val;
@@ -616,10 +616,10 @@ var setLocalStorage = function(key, value){
     if (!localStorage) { return; }
     localStorage[key] = value;
   } catch(e) {
-    if (e.code == 22 || e.code == 1014) { // Webkit == 22 / Firefox == 1014
+    if (e.code === 22 || e.code === 1014) { // Webkit == 22 / Firefox == 1014
       log('LocalStorage Full (VideoJS)', e);
     } else {
-      if (e.code == 18) {
+      if (e.code === 18) {
         log('LocalStorage not allowed (VideoJS)', e);
       } else {
         log('LocalStorage Error (VideoJS)', e);

src/js/menu/menu-button.js

@@ -105,15 +105,15 @@ class MenuButton extends Button {
   handleKeyPress(event) {
 
     // Check for space bar (32) or enter (13) keys
-    if (event.which == 32 || event.which == 13) {
+    if (event.which === 32 || event.which === 13) {
       if (this.buttonPressed_){
         this.unpressButton();
       } else {
         this.pressButton();
       }
       event.preventDefault();
     // Check for escape (27) key
-    } else if (event.which == 27){
+    } else if (event.which === 27){
       if (this.buttonPressed_){
         this.unpressButton();
       }