@dmlap Check a component is a function before new-ing. closes #2814

videojs · Nov 16, 2015 · 3852663 · 3852663
1 parent 0e1c424
commit 3852663
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,7 +2,7 @@ CHANGELOG
 =========
 
 ## HEAD (Unreleased)
-_(none)_
+* @dmlap Check a component is a function before new-ing ([view](https://github.com/videojs/video.js/pull/2814))
 
 --------------------
 

diff --git a/src/js/component.js b/src/js/component.js
@@ -373,6 +373,14 @@ class Component {
         throw new Error(`Component ${componentClassName} does not exist`);
       }
 
+      // data stored directly on the videojs object may be
+      // misidentified as a component to retain
+      // backwards-compatibility with 4.x. check to make sure the
+      // component class can be instantiated.
+      if (typeof ComponentClass !== 'function') {
+        return null;
+      }
+
       component = new ComponentClass(this.player_ || this, options);
 
     // child is a component instance