This repository has been archived by the owner on Dec 10, 2020. It is now read-only.
Don't null out the throughput timer, just reset it #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not necessary to null out the throughput timer and it could be dereferenced if the src is changed while a seek is still "in-flight". Resetting it ensures it is stopped and zeroed and it can be garbage collected along with the rest of the HTTPVideoProvider. This was causing errors in videojs-contrib-hls when the source was changed quickly after a seek was requested.
|
LGTM |
|
Specifically, reset() in Netstream.Status.SeekNotify was exploding. |
|
yeah LGTM, not sure why it was originally like that. |
dmlap
added a commit
that referenced
this pull request
Oct 2, 2014
Don't null out the throughput timer, just reset it
|
@dmlap this could use a change log entry |
heff
added a commit
to heff/video-js-swf
that referenced
this pull request
Oct 15, 2014
…p some other changelog formatting differences.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not necessary to null out the throughput timer and it could be dereferenced if the src is changed while a seek is still "in-flight". Resetting it ensures it is stopped and zeroed and it can be garbage collected along with the rest of the HTTPVideoProvider. This was causing errors in videojs-contrib-hls when the source was changed quickly after a seek was requested.