Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor cleanup in http/server.d: remove constructor + add const #1802

Merged
merged 1 commit into from
Jul 2, 2017

Conversation

wilzbach
Copy link
Member

A couple of small things that I found by making a short pass through http/server.d, btw I am always positively surprised how easy Vibe.d's code is to read 👍


this()
@safe {
// need to use the contructor because the Ubuntu 13.10 GDC cannot CTFE dur()
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since 0.7.29 gdc isn't officially supported anymore.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heh, who would have guessed that I had made the same changes yesterday :) 42fdf87

I'll merge this though and just drop that branch.

@wilzbach
Copy link
Member Author

Heh, who would have guessed that I had made the same changes yesterday :) 42fdf87
I'll merge this though and just drop that branch.

Hehe. Sorry.

image

@s-ludwig I think you need to disable the "require branch to be up-to-date" - otherwise it's an rebase nightmare (though the bot might soon be able to rebase PRs automatically).

@s-ludwig
Copy link
Member

I think you need to disable the "require branch to be up-to-date" - otherwise it's an rebase nightmare (though the bot might soon be able to rebase PRs automatically).

Already done! BTW, thanks for the detailed guide! Everything should be in place now on this side.

@s-ludwig s-ludwig merged commit 3048f34 into vibe-d:master Jul 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants