Create image command #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Debatable if this command was necessary, especially since the
waifucommand already gives amazing waifu images. I'll admit that after implementing the gif command that I got curious if its image counterpart was good as well. Well I tried it and I liked it enough to make this prMy only gripes with it tho is that it's considerably slower than the waifu api and most of the relationship data (categories, artist, source, etc) usually come back as empty. Overall tho it's pretty good and maybe I'll figure out what I can do with its other endpoints next time. Sticking with just all random for now tho
Documentation: https://v1.nekosapi.com/
Github: https://github.com/Nekidev/Nekos-API
Change