Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Holy smokes this feels like I'm at work, why the heck did this madman create a jsonapi spec on a personal project this huge. And why in the world did I go ahead in trying to consume this data smh. Jokes aside, it's great to see young peeps challenging themselves to more advanced implementation even if it means less users would be able to use it
Overall it's pretty neat, I was expecting the responses and resources returned would be filled with bugs but for the most part they're working as the spec intends it to be. There's a couple of inconsistencies with naming and a hell of a lot of missing resources but otherwise it's usable at least.
It's considerably slower tho than v1 and my goodness a hell of a lot more NSFW pics. Can't do much on the former since the optimisations have to go on their side but I can probably figure out a way to filter out the pics. I'm just worried that the quality of the images returned would plummet if I only filter in one ageRating; I don't really trust the tagging they did with the explicit content. (Some
questionable
ones return as legit NSFW)Anyway this pr adds probably 80% of the Image resource with schemas and decorators. Also updated the image command to return a more advanced embed with relevant data. I wonder if it's a good idea to make an API wrapper to help out other peeps after I finish everything tho. Heck I do this for a living and I already struggle, I imagine most people would also go through the same. I'll sleep on it
Change
Considerations
I'll do tests after finishing up the schemas. This pr is already huge enough as it is and I'd probably lose my mind if I start trying to test before relying on typescript