-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parser refactor (part 1) #143
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had a brief look at this.
|
Happypig375
commented
Jul 19, 2020
Happypig375
commented
Jul 19, 2020
Happypig375
commented
Jul 19, 2020
CSharpMath/Structures/Dictionary.cs
Outdated
/// Represents a many to one relationship between TFirsts and TSeconds, allowing fast lookup of the first TFirst corresponding to any TSecond. | ||
/// </summary> | ||
#pragma warning disable CA1710 // Identifiers should have correct suffix | ||
#pragma warning disable CA1010 // Collections should implement generic interface |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should include the above justification in a SuppressMessageAttribute
.
Co-authored-by: Hadrian Tang <hadrianwttang@outlook.com>
…Math into ParserRefactor
Happypig375
commented
Jul 19, 2020
Re-requesting @FoggyFinder's approval since there are a lot of new changes |
FoggyFinder
reviewed
Jul 22, 2020
FoggyFinder
reviewed
Jul 22, 2020
Co-authored-by: FoggyFinder <FoggyFinder@yandex.ua>
FoggyFinder
approved these changes
Jul 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Resolution/Implemented
The described enhancement or housekeeping work has been implemented.
Status/5. Awaiting next release
This issue has been resolved and is waiting for the next release/prerelease.
Type/Enhancement
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now every command is put into a central place for lookup.
Also added
\atopwithdelims
to letMathListFromLaTeX
be able to consumeMathListToLaTeX
output, and%
for comments are now supported inMathListFromLaTeX
andMathListToLaTeX
.AliasDictionary
has been split intoBiDictionary
andProxyAdder
.Contributes to #58.