-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a new annotation: vertica.com/superuser-name #578
Changes from all commits
591a00d
9e8ac88
1bda3bf
1d17e99
943c148
48ee455
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,6 +15,10 @@ on: | |
vertica-deployment-method: | ||
type: string | ||
required: false | ||
vertica-superuser-name: | ||
type: string | ||
required: false | ||
default: myadmin | ||
secrets: | ||
DOCKERHUB_USERNAME: | ||
description: 'When working with images from docker.io, this is the username for login purposes' | ||
|
@@ -44,6 +48,11 @@ on: | |
options: | ||
- admintools | ||
- vclusterops | ||
vertica-superuser-name: | ||
description: 'Vertica superuser name' | ||
type: string | ||
required: false | ||
default: myadmin | ||
|
||
jobs: | ||
|
||
|
@@ -72,6 +81,10 @@ jobs: | |
export E2E_TEST_DIRS="tests/e2e-leg-4" | ||
export VERTICA_DEPLOYMENT_METHOD=${{ inputs.vertica-deployment-method }} | ||
if [ "${VERTICA_DEPLOYMENT_METHOD}" != "vclusterops" ]; then E2E_TEST_DIRS+=" tests/e2e-leg-4-at-only"; fi | ||
export VERTICA_SUPERUSER_NAME=${{ inputs.vertica-superuser-name }} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't think we are setting this correctly. When I look at your CI run I see dbadmin being used:
https://github.com/vertica/vertica-kubernetes/actions/runs/6785933635/job/18448129113 The new parameter was added to |
||
if [ -z "${VERTICA_SUPERUSER_NAME}" -o "${VERTICA_DEPLOYMENT_METHOD}" != "vclusterops" ]; then | ||
export VERTICA_SUPERUSER_NAME="dbadmin" | ||
fi | ||
# All helm deployments will use cert-manager to create the webhook cert | ||
export HELM_OVERRIDES="--set webhook.certSource=cert-manager" | ||
scripts/run-k8s-int-tests.sh -s -e tests/external-images-s3-ci.txt | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
kind: Added | ||
body: Ability to control the name of the superuser | ||
time: 2023-11-07T09:38:13.490515872-04:00 | ||
custom: | ||
Issue: "578" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we set the default?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I set the default value in workflow_dispatch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it's picking that up though. Workflow dispatch is when you call the workflow directly from the REST API. Workflow call is when it is called by another workflow, which is what we are doing.