Fix sandbox-upgrade-happy-path #1006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roypaulin
requested review from
cchen-vertica,
fenic-fawkes,
HaoYang0000,
qindotguan and
LiboYu2
as code owners
|
I have tried more than 5 times locally and it works every time. Increasing the timeout of step55 to give it more time to pass on github actions. Feel free to try it too. |
cchen-vertica
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bug was found in sandbox-upgrade-happy-path test case. The sandbox is upgraded and then removed (unsandboxed). After unsandboxing, we restart all the pods of the former sandbox. The issue is that the subcluster that joins the main cluster is not running the same image, so we get stuck for a while in startnode(HTTPSPollNodeStateIndirectOp) until the timeout(1200s). After timeout expires, it will requeue and run
UnsandboxImageVersionReconcilerwhich will recreate the pods with the correct image and next the next startnode attempt will succeed. The solution consists in callingUnsandboxImageVersionReconcilerjust before the restart reconciler.