Missing metrics when using setServerRequestTagsProvider with a different set of tags for different requests

[mervyn-mccreight]

Version

• 4.3.3
• 4.4.0

Context

When using one Vertx instance with metrics included to host a http-server with Kotlin and Coroutines and a ServerRequestTagsProvider that returns different Tags (key + value is different) for different type of requests, metrics are missing.

Do you have a reproducer?

• https://github.com/mervyn-mccreight/vertx-metrics-bug

Steps to reproduce

Just execute the AppTest.catchMetrics test and you can see the output of the metrics.
I'd expect metrics for all GET and POST requests, but the POST request metrics are missing.
If you change the ServerRequestTagsProvider to e.g. return a Tag with the same key, but different values for different requests, the metrics are there. The same goes when you completely remove the ServerRequestTagsProvider.

Extra

• OS: MacOS, but the same happens on a linux machine
• JVM version: Tested with 17 and 19. Was able to reproduce the same behaviour with both versions.

[mervyn-mccreight]

Actually I think the example can actually be simplified even further.
You do not need two verticles to reproduce it, one is enough.

Just have a tags-provider that returns a different set of tags for different requests for a single verticle.
I'll try to simplify the example to narrow it down.

/edit: I was able to reproduce the same behavior on a simplified example. I updated the sample project for reproduction and I'll update the description if the issue.

[tsegismont]

Thank you Le ven. 10 mars 2023, 20:04, Mervyn McCreight ***@***.***> a écrit :

…

Actually I think the example can actually be simplified even further. You do not need two verticles to reproduce it, one is enough. Just have a tags-provider that returns a different set of tags for different requests for a single verticle. I'll try to simplify the example to narrow it down. — Reply to this email directly, view it on GitHub <#173 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AALOLNVEUTH7Y43J64BYCHDW3N3NLANCNFSM6AAAAAAVVU6VN4> . You are receiving this because you were assigned.Message ID: ***@***.***>

[mervyn-mccreight]

There may be a connection to micrometer-metrics/micrometer#3508
I'll try to investigate further and find out if this is really depending on vert.x or if it is an issue with micrometer-metrics.
I don't know if that is intended behaviour though, but I wouldn't know why it should be.

[mervyn-mccreight]

Seeing micrometer-metrics/micrometer#877 I'm pretty sure it is a problem with the micrometer implementation.

[tsegismont]

Right, thanks for the update. Let's keep the issue open until the upstream issue comes to a resolution.

[tsegismont]

Closing as there's nothing we can do. Workaround in this comment: micrometer-metrics/micrometer#877 (comment)

[mervyn-mccreight]

@tsegismont is it okay from your side when I delete the reproducer repository then? :)

[tsegismont]

Fine with me